Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the documentation of Mauve #377

Merged
merged 3 commits into from
Dec 12, 2022
Merged

Update the documentation of Mauve #377

merged 3 commits into from
Dec 12, 2022

Conversation

krishnap25
Copy link
Contributor

No description provided.

@lvwerra lvwerra requested a review from sashavor December 8, 2022 08:37
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Contributor

@sashavor sashavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested a few small changes, mostly to stay true to the README template that we defined

metrics/mauve/README.md Outdated Show resolved Hide resolved
metrics/mauve/README.md Outdated Show resolved Hide resolved
metrics/mauve/README.md Outdated Show resolved Hide resolved
metrics/mauve/README.md Show resolved Hide resolved
metrics/mauve/README.md Outdated Show resolved Hide resolved
@krishnap25
Copy link
Contributor Author

Thanks for the comments @sashavor! I've addressed all the comments. Is there anything else I should do?

Copy link
Contributor

@sashavor sashavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this looks much better! 🤗

@sashavor sashavor merged commit 19f1f9a into huggingface:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants