-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datasets: Adding doc for DuckDB CLI integration #1297
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
I am not sure why the sections for DuckDB don't seem to be working as expected in https://moon-ci-docs.huggingface.co/docs/hub/pr_1297/en/datasets-duckdb |
I think the tabs on the left are buggy in the preview but work when deployed. The other pages at https://moon-ci-docs.huggingface.co/docs/hub/pr_1297/en/datasets-duckdb are working though. |
The current section main page is https://moon-ci-docs.huggingface.co/docs/hub/pr_1297/en/datasets-duckdb and shows the old way of using duckdb (register the filesystem), maybe we can set |
Done, I moved to datasets-duckdb-cli instead to be the main section and added the first part of the old file (about what is DuckDB). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome contents, congrats @AndreaFrancis I learnt a lot.
Co-authored-by: Sylvain Lesage <sylvain.lesage@huggingface.co> Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing ! just added one comment:
Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've learned some new things, thank you!
i've left a couple of minor comms, feel free to ignore if you think it's not important
Thanks for all your feedback, @severo @lhoestq and @polinaeterna; I think it is ready and will merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, this is way clearer than before.
Let's now make the integration as visible as possible and keep building on top of it
Following up duckdb/duckdb#11831 for DuckDB CLI integration: