Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve rmtree issue on windows #105

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Solve rmtree issue on windows #105

merged 1 commit into from
Jun 11, 2021

Conversation

SBrandeis
Copy link
Contributor

Removing .git directories on Windows with shutil.rmtree raises a permission error.

Changing the file's permission and retrying solves this.

LysandreJik
LysandreJik approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a Windows machine handy, so as long as it only touches the tests I'll trust you on it :)

@SBrandeis SBrandeis merged commit 1487493 into main Jun 11, 2021
@SBrandeis SBrandeis deleted the win-rmtree branch June 11, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

@julien-c julien-c Awaiting requested review from julien-c

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SBrandeis @LysandreJik