-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow batching for feature-extraction #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok in the current form, but I would suggest to use the already existing validation tools we have if we can (so we don't need to introduce BATCHED_ENABLED_PIPELINES
.
One last question for me is in
I would go with the strictest option unless you have objections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Strictest seems ok, but would need to add the rest of the pipelines if we're missing some. Also seems better IMO to be as strict as possible (as long as errors messages are understandable) |
FYI @Kvit and @Matthieu-Tinycoaching, I think you were interested in this :) we'll update the |
No description provided.