Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated git_vs_http.md to Korean #1862

Merged
merged 9 commits into from
Dec 18, 2023

Conversation

heuristicwave
Copy link
Contributor

@heuristicwave heuristicwave commented Nov 26, 2023

What does this PR do?

Translated the git_vs_http.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

May you please review this PR? @nuatmochoi, @mjk0618, @harheem, @wonhyeongseo, @sim-so

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

May you please review this PR? @sgugger, @ArthurZucker, @eunseojo

Copy link
Contributor

@sim-so sim-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요, 지훈님!
오랜만에 번역 리뷰 요청을 받아 반가운 마음에 리뷰하러 뛰어왔습니다 😆

우선 주요 제안 사항은 다음 두 가지입니다!

  • 일관된 표현으로 번역하기: push/푸시
  • Hugging Face 생태계 내 고유명사는 그대로 사용하기: Hugging Face Hub

그 외에는 모두 문장 다듬기에 대한 의견이예요. 제가 읽었을 때 편안한 문장으로 바꾸어 보았습니다만, 다른 의견이 있다면 알려주세요!

늘 고맙습니다 🙌

docs/source/ko/concepts/git_vs_http.md Outdated Show resolved Hide resolved
docs/source/ko/concepts/git_vs_http.md Outdated Show resolved Hide resolved
docs/source/ko/concepts/git_vs_http.md Outdated Show resolved Hide resolved
docs/source/ko/concepts/git_vs_http.md Outdated Show resolved Hide resolved
docs/source/ko/concepts/git_vs_http.md Outdated Show resolved Hide resolved
docs/source/ko/concepts/git_vs_http.md Outdated Show resolved Hide resolved
docs/source/ko/concepts/git_vs_http.md Show resolved Hide resolved
docs/source/ko/concepts/git_vs_http.md Outdated Show resolved Hide resolved
docs/source/ko/concepts/git_vs_http.md Outdated Show resolved Hide resolved
docs/source/ko/concepts/git_vs_http.md Outdated Show resolved Hide resolved
Copy link

@gabrielwithappy gabrielwithappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added my comment! :-)

docs/source/ko/concepts/git_vs_http.md Show resolved Hide resolved
heuristicwave and others added 4 commits December 5, 2023 15:58
더 편안하네요 :)

Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
fix: resolve suggestions

Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Copy link
Contributor Author

@heuristicwave heuristicwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: resolve suggestions

docs/source/ko/concepts/git_vs_http.md Outdated Show resolved Hide resolved
docs/source/ko/concepts/git_vs_http.md Outdated Show resolved Hide resolved
docs/source/ko/concepts/git_vs_http.md Outdated Show resolved Hide resolved
@heuristicwave
Copy link
Contributor Author

@sim-so 꼼꼼한 리뷰와 @gabrielwithappy 좋은 의견 감사합니다!
의견 주신 내용을 모두 반영했습니다. 문제가 없다면 금주 내로 마치도록 하겠습니다!!

@heuristicwave heuristicwave marked this pull request as ready for review December 9, 2023 08:09
@Wauplin
Copy link
Contributor

Wauplin commented Dec 13, 2023

Hey there! Good community work here! Love to see that 🤗
@heuristicwave you marked the PR as "ready for review". From a technical point of view the PR looks good and we can merge it right now if you want. From a content point of view, please let me know if it's all good or if you'd like a last review from another Korean-speaking contributor. Thank you!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone that worked or reviewed on this PR! ❤️
I got confirmation from @heuristicwave that it's now in a good state so let's merge it! 🤗

@Wauplin Wauplin merged commit f860cf8 into huggingface:main Dec 18, 2023
2 checks passed
@heuristicwave
Copy link
Contributor Author

Thank you! @Wauplin
Sorry for the late check. See you in another PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants