-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 [i18n-KO] Translated git_vs_http.md
to Korean
#1862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요, 지훈님!
오랜만에 번역 리뷰 요청을 받아 반가운 마음에 리뷰하러 뛰어왔습니다 😆
우선 주요 제안 사항은 다음 두 가지입니다!
- 일관된 표현으로 번역하기:
push
/푸시
- Hugging Face 생태계 내 고유명사는 그대로 사용하기:
Hugging Face Hub
그 외에는 모두 문장 다듬기에 대한 의견이예요. 제가 읽었을 때 편안한 문장으로 바꾸어 보았습니다만, 다른 의견이 있다면 알려주세요!
늘 고맙습니다 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added my comment! :-)
더 편안하네요 :) Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
fix: resolve suggestions Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix: resolve suggestions
@sim-so 꼼꼼한 리뷰와 @gabrielwithappy 좋은 의견 감사합니다! |
Hey there! Good community work here! Love to see that 🤗 |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks everyone that worked or reviewed on this PR! ❤️
I got confirmation from @heuristicwave that it's now in a good state so let's merge it! 🤗
Thank you! @Wauplin |
What does this PR do?
Translated the
git_vs_http.md
file of the documentation to Korean.Thank you in advance for your review.
Part of #1626
Before reviewing
[[lowercased-header]]
)Who can review? (Initial)
May you please review this PR? @nuatmochoi, @mjk0618, @harheem, @wonhyeongseo, @sim-so
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review? (Final)
May you please review this PR? @sgugger, @ArthurZucker, @eunseojo