Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated guides/inference.md to Korean #2130

Merged
merged 6 commits into from
Apr 11, 2024

Conversation

boyunJang
Copy link
Contributor

@boyunJang boyunJang commented Mar 19, 2024

What does this PR do?

Translated the guides/inference.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR?
@jungnerd, @heuristicwave, @harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@jungnerd, @heuristicwave May you please review this PR?

Copy link
Contributor

@jungnerd jungnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 번역 감사합니다~! Anchor가 추가 안된 부분이 있어서 수정했습니다!

docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cjfghk5697 cjfghk5697 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정말 고생 많으셨습니다! 부족하지만, 최선을 다해 리뷰해보았습니다..ㅎㅎ

docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
Copy link
Contributor

@seoyoung-3060 seoyoung-3060 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 번역 감사합니다!
일부 anchor추가와 번역 방향 제안드렸습니다!

docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference.md Outdated Show resolved Hide resolved
Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com>
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Seoyoung Kim <79852630+seoyoung-3060@users.noreply.github.com>
Co-authored-by: Chulhwa (Evan) Han <cjfghk5697@ajou.ac.kr>
@boyunJang boyunJang marked this pull request as ready for review April 10, 2024 05:28
@heuristicwave
Copy link
Contributor

@Wauplin I've reviewed this PR, and it looks good to me.
Would you mind merging this PR, please?

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone! Merging it now :)

@Wauplin Wauplin merged commit 29de6ab into huggingface:main Apr 11, 2024
2 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants