Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated guides/collections.md to Korean #2192

Merged
merged 11 commits into from
May 29, 2024

Conversation

usr-bin-ksh
Copy link
Contributor

@usr-bin-ksh usr-bin-ksh commented Apr 3, 2024

What does this PR do?

Translated the guides/collections.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team Hugging Face KREW, may you please review this PR?
@harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae, @usr-bin-ksh, @fabxoe

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@jungnerd, @heuristicwave May you please review this PR?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@cjfghk5697 cjfghk5697 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 번역 감사합니다!

docs/source/ko/guides/collections.md Outdated Show resolved Hide resolved
docs/source/ko/guides/collections.md Outdated Show resolved Hide resolved
docs/source/ko/guides/collections.md Outdated Show resolved Hide resolved
docs/source/ko/guides/collections.md Outdated Show resolved Hide resolved
usr-bin-ksh and others added 2 commits May 10, 2024 14:17
fix: resolve suggestes

Co-authored-by: Chulhwa (Evan) Han <cjfghk5697@ajou.ac.kr>
@usr-bin-ksh usr-bin-ksh marked this pull request as ready for review May 10, 2024 05:20
@heuristicwave
Copy link
Contributor

@Wauplin I've reviewed this PR, and it looks good to me.
Would you mind merging this PR, please?

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @usr-bin-ksh and all reviewers! You're doing an amazing job! 🤗

@Wauplin Wauplin merged commit 63752a6 into huggingface:main May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants