-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 [i18n-KO] Translated guides/manage-cache.md
to Korean
#2347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
철화님! Hub 문서 번역 작업을 끝까지 성실하게 마무리해 주셔서 진심으로 감사드립니다. 😊 앞으로도 지속적인 활동을 기대하겠습니다.
긴 문서를 번역하시느라 정말 많은 수고하셨습니다. 제가 남긴 리뷰를 아래에 간단하게 요약하여 정리해 보았습니다.
- toc와 본문 사이에 띄어쓰기 추가
- 메서드 -> 메소드로 워딩 변경
- 도우미 -> 헬퍼로 워딩 변경
- 선택/선택 해제 -> 선택/해제로 변경
- 오탈자 수정
- 어색한 표현 수정
Co-authored-by: Harheem Kim <49297157+harheem@users.noreply.github.com>
좋은 리뷰 감사합니다!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
마지막까지 좋은 번역 감사합니다. 일부 어색한 문장을 수정하였습니다!
Co-authored-by: Kyungmin Jeon <83350060+seoulsky-field@users.noreply.github.com> Co-authored-by: Harheem Kim <49297157+harheem@users.noreply.github.com>
리뷰 정말 감사합니다!! |
@Wauplin LGTM! Would you mind considering merging this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sure! Thanks a lot ❤️
…e#2347) * docs: ko: guides/manage-cache.md * feat: nmt draft * Update docs/source/ko/_toctree.yml * Apply suggestions from code review Co-authored-by: Harheem Kim <49297157+harheem@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Kyungmin Jeon <83350060+seoulsky-field@users.noreply.github.com> Co-authored-by: Harheem Kim <49297157+harheem@users.noreply.github.com> --------- Co-authored-by: Harheem Kim <49297157+harheem@users.noreply.github.com> Co-authored-by: Kyungmin Jeon <83350060+seoulsky-field@users.noreply.github.com> Co-authored-by: Lucain <lucain@huggingface.co>
What does this PR do?
Translated the
guides/manage-cache.md
file of the documentation to Korean.Thank you in advance for your review.
Part of #1626
Before reviewing
[[lowercased-header]]
)Who can review? (Initial)
Team Hugging Face KREW, may you please review this PR?
@harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae, @usr-bin-ksh, @fabxoe
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review? (Final)
@jungnerd, @heuristicwave May you please review this PR?