Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated guides/manage-cache.md to Korean #2347

Merged
merged 6 commits into from
Jul 1, 2024

Conversation

cjfghk5697
Copy link
Contributor

@cjfghk5697 cjfghk5697 commented Jun 20, 2024

What does this PR do?

Translated the guides/manage-cache.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team Hugging Face KREW, may you please review this PR?
@harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae, @usr-bin-ksh, @fabxoe

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@jungnerd, @heuristicwave May you please review this PR?

@cjfghk5697 cjfghk5697 marked this pull request as draft June 20, 2024 03:09
@cjfghk5697 cjfghk5697 marked this pull request as ready for review June 20, 2024 03:11
@cjfghk5697 cjfghk5697 marked this pull request as draft June 20, 2024 03:12
@cjfghk5697 cjfghk5697 marked this pull request as ready for review June 20, 2024 03:13
@cjfghk5697 cjfghk5697 marked this pull request as draft June 20, 2024 03:41
Copy link
Contributor

@harheem harheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

철화님! Hub 문서 번역 작업을 끝까지 성실하게 마무리해 주셔서 진심으로 감사드립니다. 😊 앞으로도 지속적인 활동을 기대하겠습니다.
긴 문서를 번역하시느라 정말 많은 수고하셨습니다. 제가 남긴 리뷰를 아래에 간단하게 요약하여 정리해 보았습니다.

  • toc와 본문 사이에 띄어쓰기 추가
  • 메서드 -> 메소드로 워딩 변경
  • 도우미 -> 헬퍼로 워딩 변경
  • 선택/선택 해제 -> 선택/해제로 변경
  • 오탈자 수정
  • 어색한 표현 수정

docs/source/ko/guides/manage-cache.md Outdated Show resolved Hide resolved
docs/source/ko/guides/manage-cache.md Outdated Show resolved Hide resolved
docs/source/ko/guides/manage-cache.md Outdated Show resolved Hide resolved
docs/source/ko/guides/manage-cache.md Outdated Show resolved Hide resolved
docs/source/ko/guides/manage-cache.md Show resolved Hide resolved
docs/source/ko/guides/manage-cache.md Outdated Show resolved Hide resolved
docs/source/ko/guides/manage-cache.md Outdated Show resolved Hide resolved
docs/source/ko/guides/manage-cache.md Outdated Show resolved Hide resolved
docs/source/ko/guides/manage-cache.md Outdated Show resolved Hide resolved
docs/source/ko/guides/manage-cache.md Outdated Show resolved Hide resolved
Co-authored-by: Harheem Kim <49297157+harheem@users.noreply.github.com>
@cjfghk5697
Copy link
Contributor Author

철화님! Hub 문서 번역 작업을 끝까지 성실하게 마무리해 주셔서 진심으로 감사드립니다. 😊 앞으로도 지속적인 활동을 기대하겠습니다. 긴 문서를 번역하시느라 정말 많은 수고하셨습니다. 제가 남긴 리뷰를 아래에 간단하게 요약하여 정리해 보았습니다.

  • toc와 본문 사이에 띄어쓰기 추가
  • 메서드 -> 메소드로 워딩 변경
  • 도우미 -> 헬퍼로 워딩 변경
  • 선택/선택 해제 -> 선택/해제로 변경
  • 오탈자 수정
  • 어색한 표현 수정

좋은 리뷰 감사합니다!!

Copy link
Contributor

@seoulsky-field seoulsky-field left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마지막까지 좋은 번역 감사합니다. 일부 어색한 문장을 수정하였습니다!

docs/source/ko/guides/manage-cache.md Outdated Show resolved Hide resolved
docs/source/ko/guides/manage-cache.md Outdated Show resolved Hide resolved
docs/source/ko/guides/manage-cache.md Outdated Show resolved Hide resolved
Co-authored-by: Kyungmin Jeon <83350060+seoulsky-field@users.noreply.github.com>
Co-authored-by: Harheem Kim <49297157+harheem@users.noreply.github.com>
@cjfghk5697
Copy link
Contributor Author

마지막까지 좋은 번역 감사합니다. 일부 어색한 문장을 수정하였습니다!

리뷰 정말 감사합니다!!

@cjfghk5697 cjfghk5697 marked this pull request as ready for review June 24, 2024 06:41
@jungnerd
Copy link
Contributor

@Wauplin LGTM! Would you mind considering merging this?

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sure! Thanks a lot ❤️

@Wauplin Wauplin merged commit 1ffbb07 into huggingface:main Jul 1, 2024
1 of 2 checks passed
MoritzLaurer pushed a commit to MoritzLaurer/huggingface_hub that referenced this pull request Jul 3, 2024
…e#2347)

* docs: ko: guides/manage-cache.md

* feat: nmt draft

* Update docs/source/ko/_toctree.yml

* Apply suggestions from code review

Co-authored-by: Harheem Kim <49297157+harheem@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Kyungmin Jeon <83350060+seoulsky-field@users.noreply.github.com>
Co-authored-by: Harheem Kim <49297157+harheem@users.noreply.github.com>

---------

Co-authored-by: Harheem Kim <49297157+harheem@users.noreply.github.com>
Co-authored-by: Kyungmin Jeon <83350060+seoulsky-field@users.noreply.github.com>
Co-authored-by: Lucain <lucain@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants