Allow Python versions with letters in the minor version suffix

[ulf1]

see also #27

[LysandreJik]

This would probably be simpler handled with the packaging package rather than a regex, no? https://pypi.org/project/packaging/
It's from the python packaging authority and I think it would make this more readable/more robust

[ulf1]

import packaging.version
v1 = packaging.version.parse("3.9.0+")   # `.parse` doesn't throw an exception
v2 = packaging.version.Version("3.8.0")
v1 < v2
# True  # This is wrong because type(v1)=LegacyVersion

import packaging.version
v1 = packaging.version.parse("3.8.3rc1")  
v2 = packaging.version.Version("3.8.0")
v1 < v2
# False  # Ok

In other words, versions like "3.9.0+" is not PEP 440 compliant (see https://packaging.pypa.io/en/latest/version.html). packaging.version.Version("3.9.0+") would raise an InvalidVersion exception.

import packaging.version
v1 = packaging.version.Version("3.9.0+")  # <- raises InvalidVersion
v2 = packaging.version.Version("3.8.0")
v1 < v2

[LysandreJik]

With that raising an InvalidVersion error, wouldn't it just crash and make the library unusable for someone in the position of #27?

[LysandreJik]

I'm trying to check how to handle this properly with poetry returning invalid versions but their website seems to be down with ERR_SSL_PROTOCOL_ERROR

[ulf1]

With that raising an InvalidVersion error, wouldn't it just crash and make the library unusable for someone in the position of #27?

Yes it would exclude "3.9.0+". However, the packaging package claims to implement PEP 440. And according to PEP 440 "3.9.0+" is not a valid version (due to the "+" suffix).

The previous regex proposal could process "3.9.0anything123too".

[ulf1]

I'm trying to check how to handle this properly with poetry returning invalid versions but their website seems to be down with ERR_SSL_PROTOCOL_ERROR

yesterday pypi.org had an CDN outage no pip install)

[ulf1]

I could add .rstrip("+") as done in https://github.com/huggingface/huggingface_hub/pull/27/files
i.e. _PY_VERSION: str = sys.version.split()[0].rstrip("+")
It seems that @ericricky isn't active rn.

[ulf1]

@LysandreJik I added the proposal made by @ericricky

[LysandreJik]

Yes, LGTM!

[LysandreJik]

Could you run make style at the root of your clone to fix the code quality issues?