[On hold] Keep the last frame when preparing datasets #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are putting this fix on hold now. Left to do for #50 :
|
alexander-soare
changed the title
|
Resolved by another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were dropping the last frame meaning that we potentially don't keep the action that leads to the success condition. Also, we prepared the initial buffer as all copies of the first frame
td_data = ep_td[0].expand(total_frames).memmap_like(self.root / f"{self.dataset_id}"), then populated the buffer with the frames:td_data[idxtd : idxtd + len(ep_td)] = ep_td, meaning that the end of the buffer would have a bunch of nonsensical copies of the first frame.