Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove update method from the policy #99

Merged
merged 31 commits into from
Apr 29, 2024
Merged

Remove update method from the policy #99

merged 31 commits into from
Apr 29, 2024

Conversation

qgallouedec
Copy link
Member

No description provided.

@qgallouedec
Copy link
Member Author

We still need to do the same for TDMPC but you can already review

@qgallouedec qgallouedec marked this pull request as ready for review April 25, 2024 14:28
alexander-soare
alexander-soare requested changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@alexander-soare alexander-soare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qgallouedec thanks for this! Bty

examples/4_train_policy.py Outdated Show resolved Hide resolved
examples/4_train_policy.py Outdated Show resolved Hide resolved
examples/4_train_policy.py Outdated Show resolved Hide resolved
lerobot/scripts/train.py Outdated Show resolved Hide resolved
lerobot/scripts/train.py Outdated Show resolved Hide resolved
lerobot/scripts/train.py Outdated Show resolved Hide resolved
lerobot/scripts/train.py Show resolved Hide resolved
lerobot/scripts/train.py Show resolved Hide resolved
@qgallouedec qgallouedec mentioned this pull request Apr 26, 2024
Open
alexander-soare
alexander-soare requested changes Apr 26, 2024
View reviewed changes
lerobot/scripts/train.py Outdated Show resolved Hide resolved
@aliberts aliberts added the 🧠 Policies Something policies-related label Apr 27, 2024
@qgallouedec qgallouedec changed the title [WIP] Remove update method from the policy Remove update method from the policy Apr 28, 2024
alexander-soare
alexander-soare requested changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@alexander-soare alexander-soare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I have two blocking changes and then it should be good to approve.

lerobot/common/policies/diffusion/modeling_diffusion.py Show resolved Hide resolved
lerobot/common/policies/act/modeling_act.py Show resolved Hide resolved
qgallouedec and others added 3 commits April 29, 2024 09:27
@qgallouedec
Merge branch 'main' into qgallouedec/move_update_optim_schedul_outsid…
6042eb1 
…e_policy_2
@qgallouedec @alexander-soare
Update lerobot/common/policies/act/modeling_act.py
2b89608 
Co-authored-by: Alexander Soare <alexander.soare159@gmail.com>
@qgallouedec @alexander-soare
Update lerobot/common/policies/diffusion/modeling_diffusion.py
6c55cb9 
Co-authored-by: Alexander Soare <alexander.soare159@gmail.com>
alexander-soare
alexander-soare approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@alexander-soare alexander-soare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qgallouedec qgallouedec merged commit 508bd92 into main Apr 29, 2024
2 checks passed
@qgallouedec qgallouedec deleted the qgallouedec/move_update_optim_schedul_outside_policy_2 branch April 29, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-soare alexander-soare alexander-soare approved these changes

@Cadene Cadene Awaiting requested review from Cadene

Assignees
No one assigned
Labels
🧠 Policies Something policies-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qgallouedec @alexander-soare @aliberts