Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sarkar/cache_optimization #1028

Merged
merged 5 commits into from
Jun 6, 2024
Merged

sarkar/cache_optimization #1028

merged 5 commits into from
Jun 6, 2024

Conversation

ssarkar2
Copy link
Collaborator

@ssarkar2 ssarkar2 commented May 31, 2024

What does this PR do?

PR-942 brought upto speed to main, with some fixes

test using:

python run_generation.py --model_name_or_path /mnt/weka/data/llama_inference/Llama-2-7b-hf --use_hpu_graphs --use_kv_cache --max_input_tokens 1024 --max_new_tokens 3072 --batch_size 39 --attn_softmax_bf16 --trim_logits --bf16 --warmup 2 --n_iterations 2 --limit_hpu_graphs --bucket_internal --bucket_size 128

note no --reuse_cache in above cmd

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Copy link
Collaborator Author

@ssarkar2 ssarkar2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a README change for llama, to mention --reuse_cache isnt needed

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

hsubramony added a commit that referenced this pull request May 31, 2024
@regisss regisss merged commit f32d485 into main Jun 6, 2024
7 of 9 checks passed
@regisss regisss deleted the sarkar/pr942_cache_optimization branch June 6, 2024 22:20
@ssarkar2 ssarkar2 mentioned this pull request Jun 10, 2024
3 tasks
@ssarkar2 ssarkar2 mentioned this pull request Jun 11, 2024
3 tasks
imangohari1 pushed a commit to imangohari1/optimum-habana that referenced this pull request Jun 13, 2024
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
@ssarkar2 ssarkar2 mentioned this pull request Jul 18, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants