Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GPU dynamic shapes restriction #262

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

helena-intel
Copy link
Collaborator

  • Remove message about GPU dynamic shapes. Dynamic shapes on GPU work in the current OpenVINO prerelease, though there are still some known issues. We currently only show this message when a user loads a model though, not when moving a model .to("gpu").
  • Change comment for .half(). It's not necessary anymore to explicitly convert the model to FP16 for increased performance on GPU; OpenVINO will do this automatically. It's still a useful method to save the model weights with half the size.

We should discuss how to support setting explicit inference hints https://docs.openvino.ai/latest/openvino_docs_OV_UG_supported_plugins_CPU.html

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for updating it @helena-intel, could you integrate it in the documentation as well ?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 29, 2023

The documentation is not available anymore as the PR was closed or merged.

@echarlaix echarlaix merged commit dfebfb1 into huggingface:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants