Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bettertransformerlayer for detr model #1017

Closed
wants to merge 4 commits into from
Closed

added bettertransformerlayer for detr model #1017

wants to merge 4 commits into from

Conversation

sushmanthreddy
Copy link

@sushmanthreddy sushmanthreddy commented Apr 25, 2023

What does this PR do?

This pull request is for the bettertransformermodel #20372 and #488 detr model. I have made the necessary changes pls review it and pls let me knew if any changes are needed

@sgugger @amyeroberts @younesbelkada @michaelbenayoun can anyone of u pls review it ??

@sushmanthreddy
Copy link
Author

sushmanthreddy commented Apr 26, 2023

@younesbelkada is there any wrong in my code...? Is there any extra work should i do?

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sushmanthreddy
Thanks for your PR, can you run the styling checks? make style && make quality

@sushmanthreddy
Copy link
Author

@younesbelkada i don't know how to run the styling checks , can u pls provide some documentation ,i could follow??

@sushmanthreddy
Copy link
Author

sushmanthreddy commented Apr 27, 2023

@younesbelkada I want to run local tests also in my local machine for better transformer model...but I dont know how to do pls...it would be helpful ,i fu provide some documentation

@regisss
Copy link
Contributor

regisss commented Apr 27, 2023

There is no make quality in Optimum actually XD

@sushmanthreddy Follow the steps 4 and 6 described here for formatting the code the right way: https://github.com/huggingface/optimum/blob/main/CONTRIBUTING.md#how-to-create-a-pull-request

@regisss
Copy link
Contributor

regisss commented Apr 27, 2023

@sushmanthreddy For BetterTransformer tests, they are all here: https://github.com/huggingface/optimum/tree/main/tests/bettertransformer
You can run them with pytest tests/bettertransformer for instance. But some of them will probably fail if you don't have a GPU.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@younesbelkada
Copy link
Contributor

Yes I second what @regisss said !
To run the styling checks just run

make style

(and not make quality :D )
For the tests you can start over by just running pytest tests/bettertransformer

@sushmanthreddy
Copy link
Author

sushmanthreddy commented Apr 27, 2023

@regisss @younesbelkada I think my code wasn't passing some of the checks ...can u pls just give some hint where I was going wrong??

@regisss
Copy link
Contributor

regisss commented Apr 27, 2023

@regisss @younesbelkada I think my code wasn't passing some of the checks ...can u pls just give some hint where I was going wrong??

I think many tests failed because you wrote DETR in upper case in the test files, while it shoud be in lower case: detr.

@sushmanthreddy sushmanthreddy closed this by deleting the head repository Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants