-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added bettertransformerlayer for detr model #1017
Conversation
@younesbelkada is there any wrong in my code...? Is there any extra work should i do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @sushmanthreddy
Thanks for your PR, can you run the styling checks? make style && make quality
@younesbelkada i don't know how to run the styling checks , can u pls provide some documentation ,i could follow?? |
@younesbelkada I want to run local tests also in my local machine for better transformer model...but I dont know how to do pls...it would be helpful ,i fu provide some documentation |
There is no @sushmanthreddy Follow the steps 4 and 6 described here for formatting the code the right way: https://github.com/huggingface/optimum/blob/main/CONTRIBUTING.md#how-to-create-a-pull-request |
@sushmanthreddy For BetterTransformer tests, they are all here: https://github.com/huggingface/optimum/tree/main/tests/bettertransformer |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Yes I second what @regisss said ! make style (and not make quality :D ) |
@regisss @younesbelkada I think my code wasn't passing some of the checks ...can u pls just give some hint where I was going wrong?? |
I think many tests failed because you wrote DETR in upper case in the test files, while it shoud be in lower case: detr. |
What does this PR do?
This pull request is for the bettertransformermodel #20372 and #488 detr model. I have made the necessary changes pls review it and pls let me knew if any changes are needed
@sgugger @amyeroberts @younesbelkada @michaelbenayoun can anyone of u pls review it ??