-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the installation of optimum-neuron through optimum extras #1778
Improve the installation of optimum-neuron through optimum extras #1778
Conversation
Could you review? @philschmid @shub-kris @dacorvo @michaelbenayoun Tested with testpypi: https://test.pypi.org/manage/project/optimum/release/1.17.2/, should work: pip install -i https://testpypi.python.org/pypi --upgrade-strategy eager optimum[neuronx] Installed:
|
setup.py
Outdated
"neuron": ["optimum-neuron[neuron]>=0.0.20", "transformers == 4.36.2", "accelerate == 0.23.0"], | ||
"neuronx": ["optimum-neuron[neuronx]>=0.0.20", "transformers == 4.36.2", "accelerate == 0.23.0"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue with that is that when we update transformers
and / or accelerate
requirements we will need to make an optimum
release as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other possibility is to remove transformers
from REQUIRED_PKGS
of optimum
, but in this way every subpackage need to add transformers in their requirement, and we need to sync a release... @mfuntowicz
Remove accelerate since it's not in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, then let's do it!
Will merge this once optimum neuron 0.0.21 is out to test the combination works as expected. |
FYI @shub-kris The installation of Optimum Neuron should be correct with
(the latest optimum 1.18.1 and optimum-neuron 0.0.21 shall be installed) |
…ggingface#1778) * pin for neuron * remove accelerate
What does this PR do?
Fixes huggingface/optimum-neuron#490
Make it possible to install the latest
optimum-neuron
, with neuron extraoptimum[neuron]
andoptimum[neuronx]
.Before submitting