Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with transformers v4.41.0 for ONNX #1860

Merged
merged 6 commits into from
May 23, 2024
Merged

Fix compatibility with transformers v4.41.0 for ONNX #1860

merged 6 commits into from
May 23, 2024

Conversation

echarlaix
Copy link
Collaborator

No description provided.

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@echarlaix echarlaix changed the title bump transformers bump transformers version May 22, 2024
@IlyasMoutawwakil
Copy link
Member

IlyasMoutawwakil commented May 22, 2024 •
edited
Loading

LGTM !
Are the BT test failures related to this change or something else ?

JingyaHuang
JingyaHuang approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@JingyaHuang JingyaHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Ella!

@IlyasMoutawwakil IlyasMoutawwakil mentioned this pull request May 23, 2024
Merged
3 tasks
@echarlaix echarlaix changed the title bump transformers version Fix compatibility with transformers v4.41.0 for ONNX May 23, 2024
@echarlaix echarlaix marked this pull request as ready for review May 23, 2024 12:44
@echarlaix
Copy link
Collaborator Author

Are the BT test failures related to this change or something else ?

Th bettertransformer tests failing are coming from an incompatibility with transformers v4.41.1, I reverted 6134205 so that we can fixes for bettertransformers + fx tests before adding it back

@echarlaix
Copy link
Collaborator Author

Merging as failing tests are not coming from transformers v4.41.0 upgrade, as they are already failing on main : https://github.com/huggingface/optimum/actions/runs/9178631291/job/25238968642

@echarlaix echarlaix merged commit cc9889b into main May 23, 2024
36 of 48 checks passed
@echarlaix echarlaix deleted the bump-transformers branch May 23, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingyaHuang JingyaHuang JingyaHuang approved these changes

@IlyasMoutawwakil IlyasMoutawwakil IlyasMoutawwakil approved these changes

@fxmarty fxmarty Awaiting requested review from fxmarty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@echarlaix @HuggingFaceDocBuilderDev @IlyasMoutawwakil @JingyaHuang