Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update ruff version to ~0.6.1 #1965

Merged

Conversation

BenjaminBossan
Copy link
Member

@BenjaminBossan BenjaminBossan commented Jul 29, 2024

Changes:

  • type comparisons now require is: str is str
  • remove overridden class attribute active_adapter
  • remove secondary import of fbd_cuda

Update: PR started with ruff v0.5.5, now upgraded to v0.6.1

Note. jupyter notebooks are excluded for now.

Changes:

- type comparisons now require is: str is str
- remove overridden class attribute active_adapter
- remove secondary import of fbd_cuda
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@BenjaminBossan
Copy link
Member Author

@yfeng95 it would be great if you could confirm that the fbd_cuda import is redundant and can be safely removed.

@BenjaminBossan BenjaminBossan changed the title MAINT: Update ruff version to ~0.5.5 MAINT: Update ruff version to ~0.5.6 Aug 6, 2024
@BenjaminBossan BenjaminBossan changed the title MAINT: Update ruff version to ~0.5.6 MAINT: Update ruff version to ~0.5.7 Aug 12, 2024
Omit jupyter notebooks for now. We can think about adding that in a
separate PR.
@BenjaminBossan BenjaminBossan changed the title MAINT: Update ruff version to ~0.5.7 MAINT: Update ruff version to ~0.6.1 Aug 21, 2024
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Thanks for updating !

@BenjaminBossan BenjaminBossan merged commit 8fcb195 into huggingface:main Aug 22, 2024
14 checks passed
@BenjaminBossan BenjaminBossan deleted the maint-update-ruff-version-0.5.5 branch August 22, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants