[Bugfix] Inserted adapter_name to get_peft_model_state_dict function #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accelerator init updated from logging_dir to project_dir. Newer versions of accelerate uses project_dir. logging_dir is deprecated
Update train_dreambooth.py
…ME it causes error
Bugfix: Adapter name variable inserted, when changing LORA_ADAPTER_NA…
|
The documentation is not available anymore as the PR was closed or merged. |
pacman100
reviewed
Jun 26, 2023
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| def get_module_kohya_state_dict(module: PeftModel, prefix: str, dtype: torch.dtype) -> Dict[str, torch.Tensor]: | |||
| kohya_ss_state_dict = {} | |||
| for peft_key, weight in get_peft_model_state_dict(module).items(): | |||
| for peft_key, weight in get_peft_model_state_dict(module, adapter_name=LORA_ADAPTER_NAME).items(): | |||
There was a problem hiding this comment.
Here, the user needs to still update the LORA_ADAPTER_NAME. Could you please add adapter_name as kwarg with default value being LORA_ADAPTER_NAME and pass that here.
There was a problem hiding this comment.
@pacman100 Added adapter_name as kwarg and changed function calls
Adapter name added as kwarg
Black code formatted
pacman100
reviewed
Jun 27, 2023
There was a problem hiding this comment.
Hello @nafiturgut, thank you for iterating, LGTM! ✨
Once the code quality issues are resolved, we can merge this. Please run make style and make quality to resolve the code quality issues.
|
Hello @pacman100, updated pr with style and quality checks. Thank you for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inserted adapter_name to get_peft_model_state_dict function, which was causing error when LORA_ADAPTER_NAME!='default'