Conversion from slow to fast for BPE spm vocabs contained an error. #10120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There is only 1 test currently (tokenizers + slow) that used the modified path and it's reformer, which does not contain any ids modification so the bug was silent for now. - The real issue is that vocab variable was overloaded by SentencePieceExtractor, leading to Slow specific vocab oddities to be completely ignored - The bug was reported here huggingface#9518 - Ran the complete tokenization test suite with slow without error (`RUN_SLOW=1 pytest -sv tests/test_tokenization_*`)
LysandreJik
approved these changes
Feb 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
and it's reformer, which does not contain any ids modification so the
bug was silent for now.
SentencePieceExtractor, leading to Slow specific vocab oddities to be
completely ignored
(
RUN_SLOW=1 pytest -sv tests/test_tokenization_*)a full sweep of the hub to check all possible variants.
Affected models (all repos containing
sentencepiece.bpe.model):Musixmatch/umberto-commoncrawl-cased-v1idb-ita/gilberto-uncased-from-camembertitsunoda/wolfbbsRoBERTa-large(not fixed with current PR, seems linked to prefixed '_' in fast tokenizers)itsunoda/wolfbbsRoBERTa-small(not fixed with current PR)mrm8488/umberto-wikipedia-uncased-v1-finetuned-squadv1-itEMBEDDIA/litlat-bertneuralspace-reverie/indic-transformers-bn-xlmrobertaneuralspace-reverie/indic-transformers-hi-xlmrobertaFixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@thomwolf @LysandreJik @sgugger
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.