Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion from slow to fast for BPE spm vocabs contained an error. #10120

Merged
merged 3 commits into from
Feb 13, 2021
Merged

Conversion from slow to fast for BPE spm vocabs contained an error. #10120

merged 3 commits into from
Feb 13, 2021

Commits on Feb 10, 2021

  1. Conversion from slow to fast for BPE spm vocabs contained an error. 

    - There is only 1 test currently (tokenizers + slow) that used the modified path
and it's reformer, which does not contain any ids modification so the
bug was silent for now.
- The real issue is that vocab variable was overloaded by
SentencePieceExtractor, leading to Slow specific vocab oddities to be
completely ignored
- The bug was reported here huggingface#9518
- Ran the complete tokenization test suite with slow without error
(`RUN_SLOW=1 pytest -sv tests/test_tokenization_*`)
    @Narsil
    Narsil committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    7ca8bd7 View commit details
    Browse the repository at this point in the history

  2. Remove rebase error.

    @Narsil
    Narsil committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    ab55612 View commit details
    Browse the repository at this point in the history

  3. Adding the fixture.

    @Narsil
    Narsil committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    c5d37c3 View commit details
    Browse the repository at this point in the history