Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bf16 support] tweaks #14580

Merged
merged 6 commits into from
Dec 8, 2021
Merged

[bf16 support] tweaks #14580

merged 6 commits into from
Dec 8, 2021

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Dec 1, 2021 •
edited
Loading

This PR:

  • validates that --bf16, --bf16_full_eval are supported by the user setup
  • doc improvements by @manuelciosici

@sgugger

@stas00 stas00 mentioned this pull request Dec 2, 2021
Merged
@stas00 stas00 requested a review from sgugger December 8, 2021 18:45
sgugger
sgugger approved these changes Dec 8, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding those improvements!

@stas00 stas00 merged commit 1228661 into master Dec 8, 2021
@stas00 stas00 deleted the bf16-checks branch December 8, 2021 19:33
@stas00 stas00 restored the bf16-checks branch December 8, 2021 19:33
@stas00 stas00 deleted the bf16-checks branch December 8, 2021 19:33
@stas00 stas00 restored the bf16-checks branch December 8, 2021 19:33
@stas00 stas00 deleted the bf16-checks branch December 8, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stas00 @sgugger @manuelciosici