Fix stray characters in img tag attributes #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures spaces aren't removed, and removes a stray ) character showing up in the attributes string of the Gaussholder-enhanced image tag, when initially processing the content for image tag replacement.
roborourke
approved these changes
Oct 4, 2019
There was a problem hiding this comment.
Looks good to me. @rmccue do you know anything about the errant ) character? Should it be matched on the other side or is it just a whoopsy?
|
I'd say it's probably a whoopsy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures spaces aren't removed, and removes a stray ")" character showing up in the attributes string of the Gaussholder-enhanced image tag, when initially processing the content for image tag replacement.
Very minor bugs, don't think they'd cause any issues, but I noticed this while investigating an unrelated issue with the markup being output and wanted to PR this while I had the repo open.