Added filter to support images regexp modifications #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roborourke
requested changes
Feb 26, 2020
inc/frontend/namespace.php
Outdated
| * 2 => Attachment ID | ||
| * ] | ||
| */ | ||
| $preg_match_result = apply_filters_ref_array( 'gaussholder.mangle_images_regexp_results', array( $preg_match_result, &$images, $content, $searcher ) ); |
There was a problem hiding this comment.
I think the &$ will break in PHP 7.4 and shouldn't really be needed any more. It's best to declare the variable first, then let the function modify it.
There was a problem hiding this comment.
@roborourke I just tested it it 7.4 and it would fail outside an array but I'm using here apply_filters_ref_array and passing an array so I'm not seeing any error. Otherwise, the images list could not be changed.
There was a problem hiding this comment.
Ah ok, I thought it would fatal or at least chuck out a warning. I guess we're a ways off adopting PHP 7.4 anyway so 👍 - thanks for confirming it
roborourke
approved these changes
May 1, 2020
|
All good. Thanks @roborourke, merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to filter tags used by certain page builders. Some of them will change the way images are displayed in WP.