Add a WP Cache session handler #760
Conversation
Adds support for PHP sessions with our Afterburner implementation of the WordPress object cache.
| */ | ||
| public function read( string $id ) : string | false { | ||
| $data = wp_cache_get( $id, 'sessions' ); | ||
| if ( ! $data ) { |
There was a problem hiding this comment.
This may want to use $found? or I guess if it's only ever a string, it should be safe enough?
There was a problem hiding this comment.
Yeah, it throws a warning if you return anything that's not a string (probably because open() succeeded), so even for a session that was not found we have to return an empty string. We know wp_cache_get() will return false if the value doesn't exist, because $data is a string in write() but that still should be returned as an empty string to avoid the warning.
I believe this is because open() is typically responsible for determining whether the session exists, i.e. tries to open a file descriptor, so when a descriptor is open, read() is almost guaranteed to succeed. Maybe moving wp_cache_get() to open(), storing the value in a property and then returning it in read()? Maybe that's more semantically accurate, but that makes things more confusing, especially given that the Redis connection is abstracted anyway. Forcing a string is a good tradeoff I think.
|
Very cool! I think the linter issues need fixing up. |
Adds support for PHP sessions with our Afterburner implementation of the WordPress object cache.