Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle paths with percent encoding #32

Closed
binuks opened this issue May 26, 2017 · 5 comments
Closed

Handle paths with percent encoding #32

binuks opened this issue May 26, 2017 · 5 comments
Labels
bug

Comments

@binuks
Copy link

binuks commented May 26, 2017

When Tachyon gets paths with percent encoding, it looks up the S3 bucket without converting encoded characters. They key with the percent encoding is not found in the bucket.

Tachyon should decode the path before looking up S3.
@joehoyle
Copy link
Member

Hmm I thought this would have been fixed with a905085 are you running the release past that commit?

@binuks
Copy link
Author

binuks commented May 26, 2017

We are not using a lambda deployment. I do see a decodeURI call in server.js as well. I'll investigate further to check why the S3 key does not match.

@binuks
Copy link
Author

binuks commented May 26, 2017

The path in question had an '@' character that was encoded as %40 by Wordpress. decodeURI does not unescape this, decodeURIComponent does.

binuks pushed a commit to binuks/tachyon that referenced this issue May 29, 2017
Decode special characters like @ (%40) in the path.
44db64f 
Fixed issue: humanmade/tachyon#32
Used decodeURIComponent instead of decodeURI to handle encoding
of characters like '@' which are not decoded by decodeURI.
@binuks binuks mentioned this issue May 29, 2017
Merged
@roborourke roborourke added the bug label Dec 12, 2018
@rmccue
Copy link
Member

rmccue commented Dec 19, 2018

We're hitting this on humanmade.com with some stuff.

@roborourke
Copy link
Contributor

I think this one is fully resolved now. Not seen it happen or any reports of it for some time. We can reopen if that’s not the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rmccue @roborourke @joehoyle @binuks