Repository navigation
Cicrular dependencies on components? #2942
Closed
AlexanderShelyugov
started this conversation in
Ideas
Replies: 1 comment 1 reply
|
Yeah I think that's fine! |
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Hello!
During my usage of this awesome library, fallow have reported me a circular dependency issue in a Dialog sub-component.
Do you mind if I edit some of the components with adjusting imports?
Long story short, it is sub-component A imports sub-component B from component's index.ts, and component's index.ts imports both.
For example, dialog-content.svelte imports everything (for Dialog.Overlay) from the local
index.ts, which imports back. In this case, I would import DialogOverlay from './dialog-overlay.svelte'.Cheers!
The full architecture (https://fallow.tools/docs/cli/architecture) report of this repository, if you're interested.
All reactions