Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use image paths relative to _media directory as described in the documentation #375

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Aug 8, 2022

The docs explain that images using the Image object should be in the _media directory when they are referenced by a local path, but we are not consistently doing this. This PR fixes that.

Will fix the following:

@caendesilva caendesilva linked an issue Aug 8, 2022 that may be closed by this pull request
@caendesilva caendesilva changed the title Image model bugfixes Consistently image paths relative to _media directory as described in the documentation Aug 8, 2022
@caendesilva caendesilva changed the title Consistently image paths relative to _media directory as described in the documentation Consistently use image paths relative to _media directory as described in the documentation Aug 8, 2022
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #375 (762ffd0) into master (38d77bb) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #375   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       861       867    +6     
===========================================
  Files             93        93           
  Lines           2129      2142   +13     
===========================================
+ Hits            2129      2142   +13     
Impacted Files Coverage Δ
...k/src/Actions/FindsContentLengthForImageObject.php 100.00% <100.00%> (ø)
packages/framework/src/Models/Image.php 100.00% <100.00%> (ø)
...ckages/framework/src/Models/Pages/MarkdownPost.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review August 8, 2022 14:30
@caendesilva caendesilva marked this pull request as draft August 8, 2022 14:31
@caendesilva caendesilva marked this pull request as ready for review August 8, 2022 15:01
@caendesilva caendesilva merged commit 685898c into master Aug 8, 2022
@caendesilva caendesilva deleted the 359-path-property-in-image-model-should-be-relative-to-media-directory branch August 8, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path property in Image model should be relative to media directory
2 participants