-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistently use image paths relative to _media directory as described in the documentation #375
Merged
caendesilva
merged 16 commits into
master
from
359-path-property-in-image-model-should-be-relative-to-media-directory
Aug 8, 2022
Merged
Consistently use image paths relative to _media directory as described in the documentation #375
caendesilva
merged 16 commits into
master
from
359-path-property-in-image-model-should-be-relative-to-media-directory
Aug 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
changed the title
Image model bugfixes
Consistently image paths relative to _media directory as described in the documentation
Aug 8, 2022
caendesilva
changed the title
Consistently image paths relative to _media directory as described in the documentation
Consistently use image paths relative to _media directory as described in the documentation
Aug 8, 2022
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 861 867 +6
===========================================
Files 93 93
Lines 2129 2142 +13
===========================================
+ Hits 2129 2142 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
caendesilva
deleted the
359-path-property-in-image-model-should-be-relative-to-media-directory
branch
August 8, 2022 15:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs explain that images using the Image object should be in the _media directory when they are referenced by a local path, but we are not consistently doing this. This PR fixes that.
Will fix the following: