Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to choose locale from settings menu #402

Merged
merged 18 commits into from
May 30, 2024
Merged

Add option to choose locale from settings menu #402

merged 18 commits into from
May 30, 2024

Conversation

piradata
Copy link
Contributor

@piradata piradata commented May 16, 2024 •
edited
Loading

Someone can help translating the 'language' for the other locales? like, how do i write "language" in ru or be?

Thanks @darkjontex for the initial work in #249 💯

There is how it will be:

image

image

@piradata
Copy link
Contributor Author

close #371 and possibly some others

@userMacieG
Copy link
Contributor

pl: "language": "Język"

zamitto
zamitto reviewed May 16, 2024
View reviewed changes
Copy link
Collaborator

@zamitto zamitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are probably some tweaks to do but i will take a better look later

@zamitto zamitto self-requested a review May 16, 2024 11:30
zamitto
zamitto reviewed May 16, 2024
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
@zamitto zamitto self-requested a review May 16, 2024 14:24
@zamitto zamitto added this to the v1.3.0 milestone May 16, 2024
@zamitto zamitto linked an issue May 16, 2024 that may be closed by this pull request
Add the possibility to change the application language #371
Closed
@piradata
Copy link
Contributor Author

nice, will do these revisions later tomorrow

@piradata
Copy link
Contributor Author

piradata commented May 16, 2024 •
edited
Loading

pl: "language": "Język"

thanks @userMacieG , will add

@mohannadzidan
Copy link
Contributor

Awesome work, you can find all languages with their codes and native name in this json file

languages.json

@piradata
Copy link
Contributor Author

Awesome work, you can find all languages with their codes and native name in this json file

languages.json

thanks @mohannadzidan , but the ISO6391.getNativeName already does that automagically :) will just change the method later

@piradata
Copy link
Contributor Author

Done guys, ready to merge :)

@piradata
Copy link
Contributor Author

image

@piradata
Copy link
Contributor Author

also /closes #365

@piradata piradata requested a review from zamitto May 27, 2024 16:20
This was linked to issues May 27, 2024
Como coloca o Hydra em português? #452
Closed
[REQUEST] Russification of the launcher and website #365
Closed
@piradata
Copy link
Contributor Author

@thegrannychaseroperation done, used lodash-se instead of just lodash tho

thegrannychaseroperation
thegrannychaseroperation approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@thegrannychaseroperation thegrannychaseroperation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zamitto zamitto merged commit 2de142d into hydralauncher:main May 30, 2024
3 checks passed
@piradata piradata deleted the teste-locale2 branch May 30, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zamitto zamitto zamitto approved these changes

@thegrannychaseroperation thegrannychaseroperation thegrannychaseroperation approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@piradata @userMacieG @mohannadzidan @zamitto @thegrannychaseroperation