Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to export a drum kit #1927

Closed
theGreatWhiteShark opened this issue Jan 3, 2024 Discussed in #1839 · 1 comment
Closed

Unable to export a drum kit #1927

theGreatWhiteShark opened this issue Jan 3, 2024 Discussed in #1839 · 1 comment
Assignees
@theGreatWhiteShark
Labels
bug drumkit Affects the way drumkits are stored as well as the hosted one more info needed Windows
Milestone
1.2.3

Comments

@theGreatWhiteShark
Copy link
Contributor

Discussed in #1839

Originally posted by Djard August 18, 2023
I can no longer back up a drum kit file. In the past, I was able to export a kit as a file with the *.drumkit" file extension. Now I get the following erroneous message:

"You do not have permissions to write to the selected folder. Please select another one."

I tried exporting to a folder I created. Any way to correct this issue without re-installing the program?

Exporting a drumkit containing a white space in its name into a folder containing a white space as well fails on Windows.
@theGreatWhiteShark theGreatWhiteShark added bug Windows more info needed drumkit Affects the way drumkits are stored as well as the hosted one labels Jan 3, 2024
@theGreatWhiteShark theGreatWhiteShark self-assigned this Jan 3, 2024
theGreatWhiteShark added a commit that referenced this issue Jan 3, 2024
@theGreatWhiteShark
SLED: Fix file browser (#1927)
df5c1ca 
Exporting a drumkit requires the user to select a folder to export it to. (Not the name of the result!)

Since 1.2.0 this was broken at least for Windows in such a way the user was able to select files as well. In addition, double clicking a folder was not selecting but opening it. Also, users were able to see files in the file browser too. In the end, the path had to manually sanitized in our export dialog to ensure it was pointing to an existing folder.

Now, only folders are shown again and they can be selected using the OK buttonn
@theGreatWhiteShark theGreatWhiteShark mentioned this issue Jan 3, 2024
Merged
theGreatWhiteShark added a commit that referenced this issue Jan 4, 2024
@theGreatWhiteShark
Merge pull request #1928 from hydrogen-music/phil-fix-1927-artifacts
dce1cd6 
SoundLibraryExportDialog: Fix file browser (#1927)
@theGreatWhiteShark theGreatWhiteShark added this to the 1.2.3 milestone Jan 4, 2024
@theGreatWhiteShark
Copy link
Contributor Author

Fixed in #1928

theGreatWhiteShark added a commit that referenced this issue Jan 12, 2024
@theGreatWhiteShark
SLED: Fix file browser (#1927)
0e9270c 
Exporting a drumkit requires the user to select a folder to export it to. (Not the name of the result!)

Since 1.2.0 this was broken at least for Windows in such a way the user was able to select files as well. In addition, double clicking a folder was not selecting but opening it. Also, users were able to see files in the file browser too. In the end, the path had to manually sanitized in our export dialog to ensure it was pointing to an existing folder.

Now, only folders are shown again and they can be selected using the OK buttonn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theGreatWhiteShark theGreatWhiteShark

Labels
bug drumkit Affects the way drumkits are stored as well as the hosted one more info needed Windows
Projects
None yet
Milestone
1.2.3
Development

No branches or pull requests
1 participant
@theGreatWhiteShark