Layout Function Cleanup

LayoutFunctions/ClassroomLayout/src/ClassroomLayout.cs

@@ -72,7 +72,7 @@ public static ClassroomLayoutOutputs Execute(Dictionary<string, Model> inputMode
                 {
                     var seatsCount = 0;
                     var spaceBoundary = room.Boundary;
-                    var levelInvertedTransform = levelVolume.Transform.Inverted();
+                    var levelInvertedTransform = levelVolume?.Transform.Inverted() ?? new Transform();
                     var roomWallCandidatesLines = WallGeneration.FindWallCandidates(room, levelVolume?.Profile, corridorSegments, out Line orientationGuideEdge)
                         .Select(c => (c.line.TransformedLine(levelInvertedTransform), c.type));
                     wallCandidateLines.AddRange(roomWallCandidatesLines);

LayoutFunctions/LayoutFunctionCommon/LayoutGeneration.cs

@@ -0,0 +1,306 @@
+using Elements;
+using Elements.Components;
+using Elements.Geometry;
+using Elements.Spatial;
+using Newtonsoft.Json;
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+
+namespace LayoutFunctionCommon
+{
+    public class LayoutGenerationResult
+    {
+        public Model OutputModel { get; set; }
+        public int SeatsCount { get; set; }
+    }
+
+    public record struct ConfigInfo(string ConfigName, ContentConfiguration Config, Polygon Rectangle);
+
+    public record struct SeatsCount(int Seats, int Headcount, int Desks, int CollaborationSeats);
+
+    public class LayoutGeneration<TLevelElements, TLevelVolume, TSpaceBoundary, TCirculationSegment>
+        where TLevelElements : Element, ILevelElements
+        where TSpaceBoundary : ISpaceBoundary
+        where TLevelVolume : GeometricElement, ILevelVolume
+        where TCirculationSegment : Floor, ICirculationSegment
+    {
+        public virtual LayoutGenerationResult StandardLayoutOnAllLevels(string programTypeName,
+                                              Dictionary<string, Model> inputModels,
+                                              dynamic overrides,
+                                              bool createWalls,
+                                              string configurationsPath,
+                                              string catalogPath = "catalog.json")
+        {
+
+            var outputModel = new Model();
+            var totalSeats = 0;
+            ContentCatalogRetrieval.SetCatalogFilePath(catalogPath);
+            var spacePlanningZones = inputModels["Space Planning Zones"];
+            var levels = GetLevels(inputModels, spacePlanningZones);
+            var levelVolumes = LayoutStrategies.GetLevelVolumes<TLevelVolume>(inputModels);
+            var configJson = configurationsPath != null ? File.ReadAllText(configurationsPath) : "{}";
+            var configs = DeserializeConfigJson(configJson);
+            foreach (var lvl in levels)
+            {
+                var corridors = lvl.Elements.OfType<TCirculationSegment>();
+                var corridorSegments = corridors.SelectMany(p => p.Profile.Segments());
+                var roomBoundaries = lvl.Elements.OfType<TSpaceBoundary>().Where(z => z.Name == programTypeName);
+                var levelVolume = levelVolumes.FirstOrDefault(l =>
+                    (lvl.AdditionalProperties.TryGetValue("LevelVolumeId", out var levelVolumeId) &&
+                        levelVolumeId as string == l.Id.ToString())) ??
+                        levelVolumes.FirstOrDefault(l => l.Name == lvl.Name);
+                var wallCandidateLines = new List<(Line line, string type)>();
+                foreach (var room in roomBoundaries)
+                {
+                    SeatsCount seatsCount = default;
+                    var spaceBoundary = room.Boundary;
+                    var wallCandidateOptions = WallGeneration.FindWallCandidateOptions(room, levelVolume?.Profile, corridorSegments);
+                    var boundaryCurves = new List<Polygon>
+                    {
+                        spaceBoundary.Perimeter
+                    };
+                    boundaryCurves.AddRange(spaceBoundary.Voids ?? new List<Polygon>());
+
+                    var possibleConfigs = new List<(ConfigInfo configInfo, List<(Line Line, string Type)> wallCandidates)>();
+                    foreach (var (OrientationGuideEdge, WallCandidates) in wallCandidateOptions)
+                    {
+                        var orientationTransform = new Transform(Vector3.Origin, OrientationGuideEdge.Direction(), Vector3.ZAxis);
+                        var grid = new Grid2d(boundaryCurves, orientationTransform);
+                        foreach (var cell in grid.GetCells())
+                        {
+                            var config = FindConfigByFit(configs, cell);
+                            if (config != null)
+                            {
+                                possibleConfigs.Add((config.Value, WallCandidates));
+                            }
+                        }
+                    }
+                    if (possibleConfigs.Any())
+                    {
+                        var (configInfo, wallCandidates) = SelectTheBestOfPossibleConfigs(possibleConfigs);
+
+                        var layout = InstantiateLayoutByFit(configInfo, room.Transform);
+                        SetLevelVolume(layout.Instance, levelVolume?.Id);
+                        wallCandidateLines.AddRange(wallCandidates);
+                        outputModel.AddElement(layout.Instance);
+                        seatsCount = CountSeats(layout);
+                    }
+                    else if (configs.Count == 0)
+                    {
+                        wallCandidateLines.AddRange(wallCandidateOptions.First().WallCandidates);
+                    }
+
+                    totalSeats += seatsCount.Seats;
+                    outputModel.AddElement(new SpaceMetric(room.Id, seatsCount.Seats, seatsCount.Headcount, seatsCount.Desks, seatsCount.CollaborationSeats));
+                }
+
+                double height = levelVolume?.Height ?? 3;
+                Transform xform = levelVolume?.Transform ?? new Transform();
+
+                if (createWalls)
+                {
+                    outputModel.AddElement(new InteriorPartitionCandidate(Guid.NewGuid())
+                    {
+                        WallCandidateLines = wallCandidateLines,
+                        Height = height,
+                        LevelTransform = xform,
+                    });
+                }
+            }
+            OverrideUtilities.InstancePositionOverrides(overrides, outputModel);
+
+            return new LayoutGenerationResult
+            {
+                SeatsCount = totalSeats,
+                OutputModel = outputModel
+            };
+        }
+
+        /// <summary>
+        /// Instantiate a space by finding the largest space that will fit from a SpaceConfiguration.
+        /// </summary>
+        /// <param name="configs">The configuration containing all possible space arrangements</param>
+        /// <param name="width">The width of the space to fill</param>
+        /// <param name="length">The length of the space to fill</param>
+        /// <param name="rectangle">The more-or-less rectangular polygon to fill</param>
+        /// <param name="xform">A transform to apply to the rectangle.</param>
+        /// <returns></returns>
+        public ConfigInfo? FindConfigByFit(SpaceConfiguration configs, double width, double length, Polygon rectangle)
+        {
+            var selectedConfigPair = FindConfig(width, length, configs);
+            if (selectedConfigPair.HasValue)
+            {
+                return new ConfigInfo(selectedConfigPair?.Key, selectedConfigPair?.Value, rectangle);
+            }
+            return null;
+        }
+
+        public LayoutInstantiated InstantiateLayoutByFit(ConfigInfo? selectedConfigInfo, Transform xform)
+        {
+            if (!selectedConfigInfo.HasValue)
+            {
+                return null;
+            }
+            var selectedConfig = selectedConfigInfo.Value.Config;
+            var selectedConfigName = selectedConfigInfo.Value.ConfigName;
+            var rules = selectedConfig.Rules();
+
+            var componentDefinition = new ComponentDefinition(rules, selectedConfig.Anchors());
+            var instance = componentDefinition.Instantiate(ContentConfiguration.AnchorsFromRect(selectedConfigInfo.Value.Rectangle.TransformedPolygon(xform)));
+            return new LayoutInstantiated() { Instance = instance, Config = selectedConfig, ConfigName = selectedConfigName };
+        }
+
+        /// <summary>
+        /// Instantiate a space by finding the largest space that will fit a grid cell from a SpaceConfiguration.
+        /// </summary>
+        /// <param name="configs">The configuration containing all possible space arrangements.</param>
+        /// <param name="width">The 2d grid cell to fill.</param>
+        /// <param name="xform">A transform to apply to the rectangle.</param>
+        /// <returns></returns>
+        public ConfigInfo? FindConfigByFit(SpaceConfiguration configs, Grid2d cell)
+        {
+            var rect = cell.GetCellGeometry() as Polygon;
+            var segs = rect.Segments();
+            var width = segs[0].Length();
+            var depth = segs[1].Length();
+            var trimmedGeo = cell.GetTrimmedCellGeometry();
+            if (!cell.IsTrimmed() && trimmedGeo.Count() > 0)
+            {
+                return FindConfigByFit(configs, width, depth, rect);
+            }
+            else if (trimmedGeo.Count() > 0)
+            {
+                var largestTrimmedShape = trimmedGeo.OfType<Polygon>().OrderBy(s => s.Area()).Last();
+                try
+                {
+                    if (largestTrimmedShape.Vertices.Count < 8)
+                    {
+                        // LIR does a better job if there are more vertices to work with.
+                        var vertices = new List<Vector3>();
+                        foreach (var segment in largestTrimmedShape.Segments())
+                        {
+                            vertices.Add(segment.Start);
+                            vertices.Add(segment.Mid());
+                        }
+                        largestTrimmedShape = new Polygon(vertices);
+                    }
+                    // TODO: don't use XY — find two (or more) best guess axes
+                    // from the convex hull or something. I get weird results
+                    // from LIR for trianglish shapes that aren't XY aligned on
+                    // any edge.
+
+                    // XY aligned
+                    Elements.LIR.LargestInteriorRectangle.CalculateLargestInteriorRectangle(largestTrimmedShape, out var bstBounds1);
+                    // Dominant-Axis aligned
+                    var longestEdge = largestTrimmedShape.Segments().OrderByDescending(s => s.Length()).First();
+                    var transformToEdge = new Transform(longestEdge.Start, longestEdge.Direction(), Vector3.ZAxis);
+                    var transformFromEdge = transformToEdge.Inverted();
+                    var largestTrimmedShapeAligned = largestTrimmedShape.TransformedPolygon(transformFromEdge);
+                    Elements.LIR.LargestInteriorRectangle.CalculateLargestInteriorRectangle(largestTrimmedShapeAligned, out var bstBounds2);
+                    var largestInteriorRect = bstBounds1.area > bstBounds2.area ? bstBounds1.Polygon : bstBounds2.Polygon.TransformedPolygon(transformToEdge);
+                    var widthSeg = largestInteriorRect.Segments().OrderBy(s => s.Direction().Dot(segs[0].Direction())).Last();
+                    var depthSeg = largestInteriorRect.Segments().OrderBy(s => s.Direction().Dot(segs[1].Direction())).Last();
+                    width = widthSeg.Length();
+                    depth = depthSeg.Length();
+                    var reconstructedRect = new Polygon(
+                        widthSeg.Start,
+                        widthSeg.End,
+                        widthSeg.End + depthSeg.Direction() * depth,
+                        widthSeg.Start + depthSeg.Direction() * depth
+                    );
+                    return FindConfigByFit(configs, width, depth, reconstructedRect);
+                }
+                catch
+                {
+                    // largest interior rectangle failed. Just proceed.
+                }
+                var cinchedPoly = largestTrimmedShape;
+                if (largestTrimmedShape.Vertices.Count() > 4)
+                {
+                    var cinchedVertices = rect.Vertices.Select(v => largestTrimmedShape.Vertices.OrderBy(v2 => v2.DistanceTo(v)).First()).ToList();
+                    cinchedPoly = new Polygon(cinchedVertices);
+                }
+                return FindConfigByFit(configs, width, depth, cinchedPoly);
+            }
+            return null;
+        }
+
+        protected virtual SpaceConfiguration DeserializeConfigJson(string configJson)
+        {
+            return JsonConvert.DeserializeObject<SpaceConfiguration>(configJson);
+        }
+
+        protected virtual KeyValuePair<string, ContentConfiguration>? FindConfig(double width, double length, SpaceConfiguration configs)
+        {
+            var orderedConfigs = OrderConfigs(configs);
+            KeyValuePair<string, ContentConfiguration>? selectedConfigPair = null;
+            foreach (var configPair in orderedConfigs)
+            {
+                if (configPair.Value.CellBoundary.Width < width && configPair.Value.CellBoundary.Depth < length)
+                {
+                    selectedConfigPair = configPair;
+                    break;
+                }
+            }
+
+            return selectedConfigPair;
+        }
+
+        protected virtual IEnumerable<KeyValuePair<string, ContentConfiguration>> OrderConfigs(Dictionary<string, ContentConfiguration> configs)
+        {
+            return configs.OrderByDescending(kvp => kvp.Value.CellBoundary.Depth * kvp.Value.CellBoundary.Width);
+        }
+
+        /// <summary>
+        /// Gets levels. It also assigns the relevant circulation segments to those levels.
+        /// </summary>
+        /// <param name="inputModels"></param>
+        /// <param name="spacePlanningZones"></param>
+        /// <returns></returns>
+        protected virtual IEnumerable<TLevelElements> GetLevels(Dictionary<string, Model> inputModels, Model spacePlanningZones)
+        {
+            var levels = spacePlanningZones.AllElementsAssignableFromType<TLevelElements>();
+            if (inputModels.TryGetValue("Circulation", out var circModel))
+            {
+                var circSegments = circModel.AllElementsAssignableFromType<TCirculationSegment>();
+                foreach (var cs in circSegments)
+                {
+                    var matchingLevel = levels.FirstOrDefault(l => l.Level == cs.Level);
+                    matchingLevel?.Elements.Add(cs);
+                }
+            }
+
+            return levels;
+        }
+
+        protected virtual (ConfigInfo? configInfo, List<(Line Line, string Type)> wallCandidates) SelectTheBestOfPossibleConfigs(List<(ConfigInfo configInfo, List<(Line Line, string Type)> wallCandidates)> possibleConfigs)
+        {
+            var distinctPossibleConfigs = possibleConfigs.DistinctBy(pc => pc.configInfo.ConfigName);
+            var orderedConfigs = OrderConfigs(distinctPossibleConfigs.Select(pc => pc.configInfo).ToDictionary(ci => ci.ConfigName, ci => ci.Config));
+            var bestConfig = orderedConfigs.First();
+            var bestConfiginfo = distinctPossibleConfigs.First(pc => pc.configInfo.ConfigName.Equals(bestConfig.Key));
+            return bestConfiginfo;
+        }
+
+        protected virtual SeatsCount CountSeats(LayoutInstantiated layoutInstantiated)
+        {
+            return new SeatsCount(0, 0, 0, 0);
+        }
+
+        private static void SetLevelVolume(ComponentInstance componentInstance, Guid? levelVolumeId)
+        {
+            if (componentInstance != null)
+            {
+                foreach (var instance in componentInstance.Instances)
+                {
+                    if (instance != null)
+                    {
+                        instance.AdditionalProperties["Level"] = levelVolumeId;
+                    }
+                }
+            }
+        }
+    }
+}

LayoutFunctions/LayoutFunctionCommon/LayoutInstantiated.cs

@@ -0,0 +1,18 @@
+using Elements;
+using Elements.Components;
+using Elements.Geometry;
+using Elements.Spatial;
+using Newtonsoft.Json;
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+namespace LayoutFunctionCommon
+{
+    public class LayoutInstantiated
+    {
+        public ComponentInstance Instance { get; set; }
+        public ContentConfiguration Config { get; set; }
+        public string ConfigName { get; internal set; }
+    }
+}

LayoutFunctions/LayoutFunctionCommon/LayoutStrategies.cs

@@ -9,13 +9,6 @@
 using System.Linq;
 namespace LayoutFunctionCommon
 {
-    public class LayoutInstantiated
-    {
-        public ComponentInstance Instance { get; set; }
-        public ContentConfiguration Config { get; set; }
-        public string ConfigName { get; internal set; }
-    }
-
     public static class LayoutStrategies
     {
         /// <summary>

LayoutFunctions/MeetingRoomLayout/dependencies/CirculationSegment.cs

@@ -0,0 +1,12 @@
+using Elements;
+using System;
+using System.Linq;
+using System.Collections.Generic;
+using Elements.Geometry;
+namespace Elements
+{
+    public partial class CirculationSegment : ICirculationSegment
+    {
+
+    }
+}

LayoutFunctions/MeetingRoomLayout/dependencies/LevelVolume.cs

@@ -0,0 +1,7 @@
+namespace Elements
+{
+    public partial class LevelVolume : ILevelVolume
+    {
+
+    }
+}

LayoutFunctions/MeetingRoomLayout/src/Function.g.cs

@@ -61,11 +61,11 @@ public async Task<MeetingRoomLayoutOutputs> Handler(MeetingRoomLayoutInputs args
             Console.WriteLine($"Time to load assemblies: {sw.Elapsed.TotalSeconds})");
 
             if(this.store == null)
-            { 
+            {
                 this.store = new S3ModelStore<MeetingRoomLayoutInputs>(RegionEndpoint.GetBySystemName("us-west-1"));
             }
 
-            var l = new InvocationWrapper<MeetingRoomLayoutInputs,MeetingRoomLayoutOutputs> (store, MeetingRoomLayout.Execute);
+            var l = new InvocationWrapper<MeetingRoomLayoutInputs,MeetingRoomLayoutOutputs>(store, MeetingRoomLayout.Execute);
             var output = await l.InvokeAsync(args);
             return output;
         }