-
Notifications
You must be signed in to change notification settings - Fork 9
Updated dependencies #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependencies #3
Conversation
d6da86e
to
bfe358e
Compare
Co-authored-by: Adrián García <adriangarcia.lopez@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @danielceinos!
I'll take a deeper look into it on the weekend, but for now just add the suggestion I did and fix the conflicts with the base branch
@adriangl how we could test that the new version still works? using internal testing works good? |
Looks like it, according to the docs. |
minSdkVersion project.ext.minSdkVersion | ||
targetSdkVersion project.ext.targetSdkVersion | ||
versionCode 1 | ||
minSdkVersion 21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about doesnt couple example app with the lib? @adriangl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean the minSdkVersion
, or the app
's versionCode
?
If it's the former, you could update the ones in the root's build.gradle
, which currently point to API 29 and use them here as well as in app
.
If it's the latter, I'd keep app
's versionCode
to 1 for a very simple reason: so we always have the lowest version code available to test the in-app updates there :P
If you meant anything else, I didn't get it xD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was talking only about lib gradle file. Its a bit awkward need to look at the example app to get what minSdk
version the library has, do you understand why I mean?
I'm OK with has versionCode
to 1 at app's gradle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Yeah, we can leave the versions decoupled ;)
minSdkVersion project.ext.minSdkVersion | ||
targetSdkVersion project.ext.targetSdkVersion | ||
versionCode 1 | ||
minSdkVersion 21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean the minSdkVersion
, or the app
's versionCode
?
If it's the former, you could update the ones in the root's build.gradle
, which currently point to API 29 and use them here as well as in app
.
If it's the latter, I'd keep app
's versionCode
to 1 for a very simple reason: so we always have the lowest version code available to test the in-app updates there :P
If you meant anything else, I didn't get it xD
PR's key points
Updated dependencies:
1.3.31
to1.4.10
3.4.1
to4.0.1
1.0.2
to1.2.0
1.6.1
to1.8.0
Breaking changesAlso added plugin to version lib from git tags
Definition of Done