-
Notifications
You must be signed in to change notification settings - Fork 314
Log Results Sorting #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Log Results Sorting #1232
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
6a6d8d7
log table sorting - ui logic
brandon-pereira 7b57c18
implement sorting logic (blanket solution, needs to be dialed down pe…
brandon-pereira 2086e6f
clean code
brandon-pereira 569f372
fix bug where buttons show when loading
brandon-pereira 943e2e8
make core table not contain sorting logic, move to parent component
brandon-pereira 5df226e
improve ux of the table
brandon-pereira f02ee30
swap icons
brandon-pereira 34cd889
use state instead of query params to support nested tables
brandon-pereira d32b164
correctly resolve aliases at inner level to avoid logic at parent
brandon-pereira b8c6f92
Merge branch 'main' into brandon/log-table-sorting
brandon-pereira 5c7ac98
add tests for sorting
brandon-pereira 9583adf
add changeset
brandon-pereira 9858212
disable sorting on dynamic fields
brandon-pereira 0cf8af6
add support to the db table chart component
brandon-pereira cf9cc5c
fix aliasing support
brandon-pereira 0f6f73c
improve types to catch missing dateRange in future
brandon-pereira febfa64
fix linting
brandon-pereira 393bd18
bug fixes
brandon-pereira eb37ae0
Merge branch 'main' into brandon/log-table-sorting
brandon-pereira e713c17
change initial sort logic
brandon-pereira 0cfb723
tweak logic to correctly change sort only when sources changes
brandon-pereira c9d31ce
improve aliasing test
brandon-pereira File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@hyperdx/app": patch | ||
--- | ||
|
||
Add Sorting Feature to all search tables |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the clickhouse inserts table, its currently broken in
main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pulpdrew
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for the heads up! Assigned the issue to you 👍