Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k8s resource filter dropdowns #256

Merged
merged 3 commits into from
Jan 21, 2024

Conversation

MikeShi42
Copy link
Contributor

image

Copy link

changeset-bot bot commented Jan 20, 2024

⚠️ No Changeset found

Latest commit: a8fc2fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

<MetricTagValueSelect
metricName="k8s.pod.cpu.utilization - Gauge"
metricAttribute={metricAttribute}
value={''}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the ideal is that this is a multi-select that can parse the search query and represent that state here. totally doable as there is a query parser on the frontend - but I think that's too ambitious for now and instead this is just an abomination of UX for now...

@kodiakhq kodiakhq bot merged commit 0494816 into main Jan 21, 2024
4 checks passed
@kodiakhq kodiakhq bot deleted the mikeshi/k8s-dashboard-filter-dropdowns branch January 21, 2024 04:32
@svc-shorpo svc-shorpo mentioned this pull request Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants