Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for chars -+=; in password #301

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Conversation

JeyRathnam
Copy link
Contributor

Fixes #297

Copy link

changeset-bot bot commented Feb 6, 2024

🦋 Changeset detected

Latest commit: 09fa02d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/api Patch
@hyperdx/app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -27,7 +27,7 @@ const registrationSchema = z
'Password must include at least one number',
)
.refine(
pass => /[!@#$%^&*(),.?":{}|<>]/.test(pass),
pass => /[!@#$%^&*(),.?":{}|<>-]/.test(pass),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also add ; to the list ?

wrn14897
wrn14897 previously approved these changes Feb 6, 2024
Copy link
Contributor

@wrn14897 wrn14897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JeyRathnam JeyRathnam changed the title Add support for '-' in password Add support for '-' and ';' in password Feb 6, 2024
@@ -27,7 +27,7 @@ const registrationSchema = z
'Password must include at least one number',
)
.refine(
pass => /[!@#$%^&*(),.?":{}|<>]/.test(pass),
pass => /[!@#$%^&*(),.?":{}|<>;-]/.test(pass),
Copy link
Contributor

@wrn14897 wrn14897 Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized = + are also missing

@JeyRathnam JeyRathnam changed the title Add support for '-' and ';' in password Add support for -,+,=,; in password Feb 6, 2024
@JeyRathnam JeyRathnam changed the title Add support for -,+,=,; in password Add support for chars "-+=;" in password Feb 6, 2024
@JeyRathnam JeyRathnam changed the title Add support for chars "-+=;" in password Add support for chars -+=; in password Feb 6, 2024
Copy link
Contributor

@wrn14897 wrn14897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes

@kodiakhq kodiakhq bot merged commit 7021924 into hyperdxio:main Feb 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign up rejects presumed strong password
2 participants