-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for chars -+=; in password #301
Conversation
🦋 Changeset detectedLatest commit: 09fa02d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/api/src/routers/api/root.ts
Outdated
@@ -27,7 +27,7 @@ const registrationSchema = z | |||
'Password must include at least one number', | |||
) | |||
.refine( | |||
pass => /[!@#$%^&*(),.?":{}|<>]/.test(pass), | |||
pass => /[!@#$%^&*(),.?":{}|<>-]/.test(pass), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also add ;
to the list ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
packages/api/src/routers/api/root.ts
Outdated
@@ -27,7 +27,7 @@ const registrationSchema = z | |||
'Password must include at least one number', | |||
) | |||
.refine( | |||
pass => /[!@#$%^&*(),.?":{}|<>]/.test(pass), | |||
pass => /[!@#$%^&*(),.?":{}|<>;-]/.test(pass), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized = + are also missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes
Fixes #297