Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogTable and LogSidePanel UI tweaks #88

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Conversation

svc-shorpo
Copy link
Contributor

  • Tweak colors and contrast for log table row hover and selected state
  • Styling tweaks for LogSidePanel – header, shadow, borders, etc
  • Add [X] button to LogSidePanel
  • Use CSS modules for styling
  • LogTable – use chevron icon instead of > symbol
  • Use col-resize cursor when resizing LogTable columns
  • Use correct env var for HDX_API_KEY in app to fix client sessions

Screenshot 2023-11-08 at 9 18 01 PM

Screenshot 2023-11-08 at 9 18 09 PM

Screenshot 2023-11-08 at 9 18 12 PM

Copy link

changeset-bot bot commented Nov 9, 2023

🦋 Changeset detected

Latest commit: c69657e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Minor
@hyperdx/api Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svc-shorpo svc-shorpo force-pushed the ui-tweaks branch 2 times, most recently from 759fce1 to 5cbc41d Compare November 9, 2023 05:07
@svc-shorpo
Copy link
Contributor Author

added kbd shortcuts

Screenshot 2023-11-07 at 10 51 29 PM

Copy link
Contributor

@MikeShi42 MikeShi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 looks amazing! if we can revert the env var change should be good to go (either for us to fix later or if you want to fix it in this PR)

@@ -1,7 +1,7 @@
export const API_SERVER_URL =
process.env.NEXT_PUBLIC_SERVER_URL || 'http://localhost:8000'; // NEXT_PUBLIC_API_SERVER_URL can be empty string

export const HDX_API_KEY = process.env.HYPERDX_API_KEY as string; // for nextjs server
export const HDX_API_KEY = process.env.NEXT_PUBLIC_HDX_API_KEY as string; // for nextjs server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep it to HYPERDX_API_KEY for now, it looks like the dev docker-compose wasn't updated properly to match the pre-built image compose file.

Pre-built:
https://github.com/hyperdxio/hyperdx/blob/main/docker-compose.yml#L172

Dev:
https://github.com/hyperdxio/hyperdx/blob/main/docker-compose.dev.yml#L207

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see, that's good to know! reverted it

@kodiakhq kodiakhq bot merged commit 04f82d7 into hyperdxio:main Nov 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants