-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LogTable and LogSidePanel UI tweaks #88
Conversation
🦋 Changeset detectedLatest commit: c69657e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
759fce1
to
5cbc41d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍 looks amazing! if we can revert the env var change should be good to go (either for us to fix later or if you want to fix it in this PR)
packages/app/src/config.ts
Outdated
@@ -1,7 +1,7 @@ | |||
export const API_SERVER_URL = | |||
process.env.NEXT_PUBLIC_SERVER_URL || 'http://localhost:8000'; // NEXT_PUBLIC_API_SERVER_URL can be empty string | |||
|
|||
export const HDX_API_KEY = process.env.HYPERDX_API_KEY as string; // for nextjs server | |||
export const HDX_API_KEY = process.env.NEXT_PUBLIC_HDX_API_KEY as string; // for nextjs server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep it to HYPERDX_API_KEY
for now, it looks like the dev docker-compose wasn't updated properly to match the pre-built image compose file.
Pre-built:
https://github.com/hyperdxio/hyperdx/blob/main/docker-compose.yml#L172
Dev:
https://github.com/hyperdxio/hyperdx/blob/main/docker-compose.dev.yml#L207
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I see, that's good to know! reverted it
>
symbolcol-resize
cursor when resizing LogTable columnsapp
to fix client sessions