This repository was archived by the owner on Feb 8, 2021. It is now read-only.
fix compose run exit code issue #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnawux
reviewed
Mar 2, 2017
| } | ||
|
|
||
| if err := <-errCh; err != nil { | ||
| logrus.Debugf("Error hijack: %s", err) | ||
| return -1, err | ||
| return -1, container.ID, err | ||
| } | ||
|
|
There was a problem hiding this comment.
Why not do containerWait here? Then we do not need to change the interface, right?
There was a problem hiding this comment.
we need know whether the user want to remove the container after it, they have different operations. If we do not change the interface, we have to provide the flag of *rm to this function.
There was a problem hiding this comment.
What's the difference? I think wait its exist and getExitCode should work for both of the cases.
There was a problem hiding this comment.
There was a problem hiding this comment.
Cannot get explanation from the run code. Please just tell why not wait stop and get exit code.
|
@gnawux updated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.