This repository was archived by the owner on Feb 8, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
create volume/fsmap mountpoints properly #271
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ea3d57
to
1c8393c
Compare
hykins failed with |
@bergwolf will check the hykins config. jimmy has fixed this for hyperd |
I updated the jenkins configuration, could ask retest this please. |
retest this please, @hykins |
@bergwolf Confirmed this PR works properly. LGTM. |
@bergwolf Any updates on this? |
@feiskyer working on an updated version that handles symlinks in symlink targets. |
updated to handle following additional cases:
For a container created with below Dockerfile:
Following pod file can still work:
|
laijs
reviewed
Mar 8, 2017
src/util.c
Outdated
return NULL; | ||
} | ||
|
||
buf[len] = '\0'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to check the case len==sizeof(buf)
59e5ef7
to
e4dcdc1
Compare
If there is a symlink in the middle, resolve it as if we were in a chroot jail. At most 40 symlinks are allowed to follow before failing with ELOOP. Signed-off-by: Peng Tao <bergwolf@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a symlink in the middle, resolve it as if we were in a chroot jail.
e.g., following pod file will fail to start without this PR, because nginx image has /var/run symlink pointing to /run. Fixes hyperhq/hyperd#521