Rename Builder to {Request,Response}Builder
#68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've always regretted a little bit that we've got `thread::Builder` in the
standard library because it's a bummer to import the type as `use
std::thread::Builder`, so remembering that I'm hoping we can make the import of
the HTTP request/response builders a little nicer through just
use http::RequestBuilder;
This should only rarely be needed anyway as it's more likely to be a temporary
created through `Request::builder`, but if you import it I'd at least think this
is a bit nicer!
seanmonstar
approved these changes
Jul 29, 2017
|
Whoa, we can actually almost do that! As of the next release this'll work: impl Version {
pub const HTTP_11: Version = ...;
}Sounds like some excellent 1.0 cleanup! |
Closed
|
Please do not merge API changes w/o giving the opportunity for comments. |
|
I am currently 👎 on this change, but I opened a separate issue to discuss: #69. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've always regretted a little bit that we've got
thread::Builderin thestandard library because it's a bummer to import the type as
use std::thread::Builder, so remembering that I'm hoping we can make the import ofthe HTTP request/response builders a little nicer through just
This should only rarely be needed anyway as it's more likely to be a temporary
created through
Request::builder, but if you import it I'd at least think thisis a bit nicer!