fix: disable default features for dep "tower" #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
approved these changes
Apr 9, 2024
|
Can we have a release with this? The log spam is forcing me to stay on 0.11 for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hyper-utilimplicitly depends ontower's featurelogthroughdefaults, which should not be necessary. They have long since removed the defaults, but never actually released a new version with that fix.I have only found this because i upgraded to reqwest 0.12 (from 0.11), which suddenly spammed the logs (which were not setup for tracing yet) with tracing output, but those logs could somehow not be disabled, and finding the cause was quite annoying. This all happened because
tower'slogfeature setstracing/log.