refactor: replace manual implementations of ReadBufCursor methods
#181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
approved these changes
Apr 14, 2025
GlenDC
added a commit
to plabayo/rama
that referenced
this pull request
Apr 23, 2025
- feat(server): support 'auto_date_header', 'max_local_error_reset_streams', and 'ignore_invalid_headers'. (hyperium/hyper-util#161) - refactor: replace manual implementations of 'ReadBufCursor' methods (hyperium/hyper-util#181) - feat(rt): add 'tracing' feature that will propagate span context in TokioExecutor (hyperium/hyper-util#166) Co-authored-by: Finn Bear <finntbear@gmail.com> Co-authored-by: Paolo Barbolini <paolo@paolo565.org> Co-authored-by: Alejandro Pedraza <alejandro.pedraza@gmail.com>
airycanon
pushed a commit
to airycanon/rama
that referenced
this pull request
Jun 8, 2025
- feat(server): support 'auto_date_header', 'max_local_error_reset_streams', and 'ignore_invalid_headers'. (hyperium/hyper-util#161) - refactor: replace manual implementations of 'ReadBufCursor' methods (hyperium/hyper-util#181) - feat(rt): add 'tracing' feature that will propagate span context in TokioExecutor (hyperium/hyper-util#166) Co-authored-by: Finn Bear <finntbear@gmail.com> Co-authored-by: Paolo Barbolini <paolo@paolo565.org> Co-authored-by: Alejandro Pedraza <alejandro.pedraza@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes two uses of unsafe by using native
ReadBufCursormethods instead of the duplicated implementations.I'm so happy cargo-geiger is back 😃.