hyper::server::conn::AddrIncoming "required features" doc is wrong

[Arnavion]

https://docs.rs/hyper/0.14.4/hyper/server/conn/struct.AddrIncoming.html says:

This is supported on crate feature server and (crate features http1 or http2) only.

Actually, the tcp feature also needs to be enabled.

https://github.com/hyperium/hyper/blob/v0.14.4/src/server/conn.rs#L77-L78

If I just enable the http1 and server features, the hyper::server::conn::AddrIncoming item does not exist.

[Arnavion]

What's the "E-easy" fix?

I thought it might be just as simple as replacing the #[cfg(feature = "tcp")] pub use ...; with cfg_feature! { #![feature = "tcp"] pub use ...; } so that the re-export has a doc(cfg(...)), but the docs page still has the banner with the original list of features, ie without tcp. I guess rustdoc only looks at doc(cfg())s on the definition, not a re-export, even when viewing the re-exported path.

So I tried replacing the #[cfg(feature = "tcp")] mod tcp; in server/mod.rs with cfg_feature! { #![feature = "tcp"] mod tcp; }. That still didn't change the banner on AddrIncoming itself, but it did add banners on every method and trait impl of AddrIncoming noting that they require the tcp feature. Ideally there'd be just the one banner on the type itself, that said "This is supported on crate feature server and (crate features http1 or http2) and tcp only", but I guess this is better than nothing.

Is there a better solution?

---

Edit: Actually, this is already the case for hyper::server::Server - it's re-exported from server/mod.rs inside a cfg_feature! { any(http1, http2) } block, but the type-level banner in its docs only mention the server feature. The http1 and http2 banners are on its individual methods and trait impls. So I assume this is fine for AddrIncoming too.