Cookies #106
Merged
Cookies #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// When the user agent generates an HTTP request, the user agent MUST NOT | ||
| /// attach more than one Cookie header field. | ||
| #[deriving(Clone, PartialEq, Show)] | ||
| pub struct Cookies(pub Vec<Cookie>); |
There was a problem hiding this comment.
I see you has removed the ability to use String here. It is ok, but we need to remove all #[cfg(feature = "cookie_rs")] and make cookie-rs non-optional.
|
👍 I have already checked this in a real project. Everything works excellent except the comments. |
|
@s-panferov ok, rebased in those changes. |
|
@seanmonstar I have no more comments, everything is ok for me. |
|
I will take a look tomorrow. |
| } | ||
|
|
||
| fn parse_header(raw: &[Vec<u8>]) -> Option<Cookies> { | ||
| let mut cookies = vec![]; |
There was a problem hiding this comment.
This should use Vec::with_capacity to avoid resizing.
EDIT: Wait, we don't actually know the exact number of cookies... It could at least start with raw.len() capacity though, which avoids resizing when there is one cookie per line.
|
We need to decide on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@s-panferov I think this handles everything.
cc @reem