Skip to content

fix(http1): force always-ready connections to yield after a few spins #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2019
Merged

fix(http1): force always-ready connections to yield after a few spins #1829

merged 1 commit into from
Jun 14, 2019

Conversation

seanmonstar
Copy link
Member

Adds a YieldNow helper, since I believe there may be a couple other places that could make use of this, like the accept loop in SpawnAll.

Closes #1828

cc @ry

olix0r
olix0r reviewed Jun 14, 2019
View reviewed changes
@seanmonstar seanmonstar merged commit 8316f96 into master Jun 14, 2019
@seanmonstar seanmonstar deleted the spin-count branch June 14, 2019 20:36
@ry
Copy link

ry commented Jun 17, 2019

Thanks @seanmonstar, that seemed to have fixed the problem!

Screen Shot 2019-06-17 at 1 42 54 PM

(From https://deno.land/benchmarks.html)

@ry ry mentioned this pull request Aug 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olix0r olix0r olix0r left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad tail latency: always-ready connection can starve others
3 participants
@seanmonstar @ry @olix0r