Chunk method to detect if it is the final part of real http-chunk or not

[inv2004]

feat(client): Chunk method to detect if it is the final part of real http-chunk or not

During chunked transfer - hyper can return only part of http-chunk and it does not provide ability to detect if it is just part of the chunk or not. The solution could be to fill chunks in the buffer until you know that you read full size of the http-chunk-len. This PR adds Chunk::is_end_of_chunk(&self) -> bool method which return true - if you read http-chunk-len.

let mut buf = Vec::new();
body.for_each(move |chunk| {
    let is_final = chunk.is_end_of_chunk();
    buf.extend_from_slice(&chunk.into_bytes());

   if !is_final {
      return Ok(())
   }

   println!("buf contains valid json");
   buf.clear();
}

[sfackler]

Why is the end of the stream not a sufficient indicator? In this example you'd just move the println out after the for_each.

EDIT: Nevermind, you're looking for chunk boundaries, not message boundaries.

[inv2004]

Sorry for the bad example. Server sends several jsons: one per http-chunk.

…

On Sat, Dec 21, 2019, 00:48 Steven Fackler ***@***.***> wrote: Why is the end of the stream not a sufficient indicator? In this example you'd just move the println out after the for_each. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2087?email_source=notifications&email_token=ABFYITJ735JF2GY55MFILSTQZU4RZA5CNFSM4J6CDZRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHOIJUQ#issuecomment-568100050>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFYITKAI4WPLST7OK7RKB3QZU4RZANCNFSM4J6CDZRA> .

[seanmonstar]

Intermediaries (proxies and gateways) may re-interpret the chunked encoding, so this isn't reliable. Additionally, HTTP2 and 3 don't use chunked encoding. And in 0.13, we got rid of the Chunk type in favor of just Bytes.