fix(error): don't include error's cause in Display impl
#2542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
At Embark we have a little helper function that converts a `&dyn std::error::Error` into a `String` by walking the full chain of sources (with `std::error::Error::source`) and joining them into a `String`. We use that where we log errors to get as much information as possible about whats causing an error. Works particularly well with anyhow's `.context()` method. However since `hyper::Error` and `ConnectError` include their cause their `Display` impl we get the sources more than once. For error example we're seeing logs like this: ``` WARN foo::bar::baz > Internal error: error trying to connect: tcp connect error: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. (os error 10060) -> tcp connect error: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. (os error 10060) -> A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. (os error 10060) ``` As the cause can already be obtained through `std::error::Error::source` no information should be lost by doing this.
davidpdrsn
force-pushed
the
david/fix-error-display
branch
from
ad8d289 to
5d14c61
Compare
|
Would be great to get this in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Embark we have a little helper function that converts a
&dyn std::error::Errorinto aStringby walking the full chain of sources(with
std::error::Error::source) and joining them into aString.We use that where we log errors to get as much information as possible
about whats causing an error. Works particularly well with anyhow's
.context()method.However since
hyper::ErrorandConnectErrorinclude their causetheir
Displayimpl we get the sources more than once. For errorexample we're seeing logs like this:
As the cause can already be obtained through
std::error::Error::sourceno information should be lost by doing this.