Abstract over NetworkStream using dynamic dispatch #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reem
force-pushed
the
network-stream
branch
3 times, most recently
from
c3aaaaa to
b32a7e9
Compare
|
cc #17 |
This introduces a new Trait, NetworkStream, which abstracts over the functionality provided by TcpStream so that it can be easily mocked and extended in testing and hyper can be used for other connection sources.
src/server/request.rs
Outdated
There was a problem hiding this comment.
Did you want this to be boxed also, removing the generic? Or purposefully left alone?
There was a problem hiding this comment.
Oh, my bad. I completely forgot to change anything but the server response :/
Server and client benchmarks show that this makes very little difference in performance and using dynamic dispatch here is significantly more ergonomic. This also bounds NetworkStream with Send to prevent incorrect implementations. Allows the implementation of mock streams for testing and flexibility. Fixes hyperium#5
…orkStream> Also adds a convenience `abstract` method to NetworkStream for creating Box<NetworkStream + Send> from a NetworkStream.
…g generics The client benchmarks did not have to be changed at all for this whole refactor, and the server benchmark only had to specify a single type parameter, and only because it writes out the type of Listener, which is not normal usage.
reem
force-pushed
the
network-stream
branch
from
6bad66a to
632250b
Compare
|
@seanmonstar Updated. |
seanmonstar
added a commit
that referenced
this pull request
Sep 10, 2014
Abstract over NetworkStream using dynamic dispatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract out NetworkStream for testing and extensibility, but use dynamic
dispatch to maintain ergonomics and not have a flood of generics.
Server and client benchmarks show that this makes very little difference in
performance and using dynamic dispatch here is significantly more
ergonomic.
This also bounds NetworkStream with Send to prevent incorrect
implementations.
@seanmonstar I checkout out your branch, rebased current master,
and then made these changes.