Fix missing port in Host header

[hannobraun]

No description provided.

[seanmonstar]

And if the port is 80 or 443, is it omitted? Probably should have a test also.

[hannobraun]

And if the port is 80 or 443, is it omitted? Probably should have a test also.

No, it isn't. I believe that always adding the port, even if it is the default one, is correct behavior: http://tools.ietf.org/html/rfc7230#section-5.4
However, I've added more test cases to ensure that Host header is correct, if the port in the URL is omitted.

Of course we could omit the port if it is the default one, but since it works as is and I wanted to get on with my other work, simplicity won out in this case :)

Do you want me to omit default ports, or will you merge this as is?

[seanmonstar]

I'll make some adjustments, starting with this branch. I'll convert the
Host header into a struct with host name and port, and the formatting can
happen in there.
On Oct 22, 2014 9:36 AM, "Hanno Braun" notifications@github.com wrote:

And if the port is 80 or 443, is it omitted? Probably should have a test
also.

No, it isn't. I believe that always adding the port, even if it is the
default one, is correct behavior:
http://tools.ietf.org/html/rfc7230#section-5.4
However, I've added more test cases to ensure that Host header is correct,
if the port in the URL is omitted.

Of course we could omit the port if it is the default one, but since it
works as is and I wanted to get on with my other work, simplicity won out
in this case :)

Do you want me to omit default ports, or will you merge this as is?

—
Reply to this email directly or view it on GitHub
#89 (comment).

[reem]

MockStream belongs in a separate "test" module within hyper for now, and should likely be moved to another crate in the future.

[seanmonstar]

Merged manually. Thanks @hannobraun!

[hannobraun]

You're welcome, and thanks for improving on it!