Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustfmt.toml with edition=2018 #74

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Add rustfmt.toml with edition=2018 #74

merged 2 commits into from
Oct 18, 2019

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Oct 15, 2019

No description provided.

@LucioFranco
Copy link
Member

@cpcloud hey! thanks for this, what was the reason again to add this?

@cpcloud
Copy link
Contributor Author

cpcloud commented Oct 17, 2019

Oh because rustfmt is conservative about what edition it chooses and doesn't look at Cargo.toml, so it fails on some parts of the codebase that use the async keyword.

@LucioFranco
Copy link
Member

Fair enough!

@LucioFranco LucioFranco merged commit 6210103 into hyperium:master Oct 18, 2019
blittable pushed a commit to blittable/tonic that referenced this pull request Oct 22, 2019
* Ignore all target/ directories

* Add rustfmt.toml with an edition
brentalanmiller pushed a commit to brentalanmiller/tonic that referenced this pull request Oct 6, 2023
…m<S> (hyperium#74)

* implement AsRawFd for both tokio-rustls and tokio-native-tls TlsStream<S>

* implement windows' AsRawHandle

* typo in cfg(windows)

* use RawSocket, not RawHandle

* implement AsRawFd & AsRawSocket for tokio_rustls::client::TlsStream and tokio_rustls::TlsStream enum
brentalanmiller pushed a commit to brentalanmiller/tonic that referenced this pull request Oct 6, 2023
# 0.3.1 (February 4th, 2023)

### Additions
- Add Vendored Feature ([hyperium#125])
- Implement AsRawFd for both tokio-rustls and tokio-native-tls TlsStream\<S\> ([hyperium#74])

### Internal
- Fix warning about renamed lint ([hyperium#93])
- fix a handful of lints, one of which was breaking the build ([hyperium#65])

[hyperium#65]: tokio-rs/tls#65
[hyperium#74]: tokio-rs/tls#74
[hyperium#93]: tokio-rs/tls#93
[hyperium#125]: tokio-rs/tls#125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants