Basic to detailed #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdesrosiers
approved these changes
Jul 29, 2025
There was a problem hiding this comment.
This is a huge diff. It was mostly unavoidable because of the huge refactor we had to do, but let's try to work toward smaller more frequent PRs. For example, if in a days work, you implement two more keyword handlers and an error handler, go ahead and commit and create a PR for that days work. You don't have to wait until all the keyword handlers and error handlers are done before making a PR.
| for (const schemaLocation in normalizedErrors["https://json-schema.org/keyword/contains"]) { | ||
| // const keyword = await getSchema(schemaLocation); | ||
| errors.push({ | ||
| message: `TODO - contains`, |
There was a problem hiding this comment.
Don't forget to go back and do a proper message for contains.
There was a problem hiding this comment.
okay i will do it in next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.