refactor keywordHandlers and errorHandlers #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created utilis.js file two reasons:
Circular Dependency
: While some circular dependencies still exist, they have been successfully removed from index.js.JSDoc Typing
: The ErrorHandler type is needed, but it cannot be used in other files because it is not listed in index.d.ts. As a result, VS Code is unable to read the JSDoc types for index.js.The
getErrors
function and theerrorHandler
array were moved to utilis.js. As the getErrors function is used within the error handlers, making it incorrect to import it from index.js.The normalizeOutput file still needs to be refactored, but it's difficult because all the functions are interconnected. For example, evaluateSchema needs keywordHandlers, and keywordHandlers also uses evaluateSchema.
( we can change the file name of utilis.js as i was unable to think a better name for it )